Conversation
JusterZhu
added a commit
that referenced
this pull request
Jun 20, 2026
… glue code, and performance issues This commit addresses the full audit review of GeneralUpdate.Core: **Bug fixes:** - Remove HasExited race condition in WindowsStrategy & MacStrategy (#3,#4) - Only rollback when no version succeeded yet in AbstractStrategy (#5) - Guard against null version.Name in DeleteVersionZip (#6) - Better semaphore timeout logging in DefaultDownloadOrchestrator (#8) - Robust concurrent-safe DeleteDirectory in StorageManager (#10) - Add re-entry guard in AbstractStrategy.ExecuteAsync (#11) **Design improvements:** - Fix XML doc to match actual validation in UpdateRequest.Validate() (#12) - Unify SSL policy: VersionService delegates to HttpClientProvider (#16,#17) - GracefulExit self-shutdown no longer calls Kill() on the current process (#18) - Use StartsWith instead of IndexOf in BlackMatcher.ShouldSkipDirectory (#19) - Replace lock with ConcurrentDictionary.GetOrAdd in Option.ValueOf (#20) **Glue code removal:** - Extract shared BlackDefaults.CreatePolicyWithDefaults() (#21) - Remove duplicate CallSmallBowlHomeAsync from Bootstrap (#22) - Extract shared OsStrategyResolver class (#23) - Make SafeOnBeforeUpdateAsync semantics consistent: exception = abort (#24) **Performance:** - Cache parsed SemVers in DownloadPlanBuilder to avoid repeated parsing (#26) - Reuse Sha256HashAlgorithm as static field in HashMiddleware (#30) - Add CleanupOldTempDirectories() to prevent temp directory accumulation (#31) Co-authored-by: Claude <noreply@anthropic.com>
JusterZhu
added a commit
that referenced
this pull request
Jun 20, 2026
… glue code, and performance issues This commit addresses the full audit review of GeneralUpdate.Core: **Bug fixes:** - Remove HasExited race condition in WindowsStrategy & MacStrategy (#3,#4) - Only rollback when no version succeeded yet in AbstractStrategy (#5) - Guard against null version.Name in DeleteVersionZip (#6) - Better semaphore timeout logging in DefaultDownloadOrchestrator (#8) - Robust concurrent-safe DeleteDirectory in StorageManager (#10) - Add re-entry guard in AbstractStrategy.ExecuteAsync (#11) **Design improvements:** - Fix XML doc to match actual validation in UpdateRequest.Validate() (#12) - Unify SSL policy: VersionService delegates to HttpClientProvider (#16,#17) - GracefulExit self-shutdown no longer calls Kill() on the current process (#18) - Use StartsWith instead of IndexOf in BlackMatcher.ShouldSkipDirectory (#19) - Replace lock with ConcurrentDictionary.GetOrAdd in Option.ValueOf (#20) **Glue code removal:** - Extract shared BlackDefaults.CreatePolicyWithDefaults() (#21) - Remove duplicate CallSmallBowlHomeAsync from Bootstrap (#22) - Extract shared OsStrategyResolver class (#23) - Make SafeOnBeforeUpdateAsync semantics consistent: exception = abort (#24) **Performance:** - Cache parsed SemVers in DownloadPlanBuilder to avoid repeated parsing (#26) - Reuse Sha256HashAlgorithm as static field in HashMiddleware (#30) - Add CleanupOldTempDirectories() to prevent temp directory accumulation (#31) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.